add renderBlock but not ancient#2884
Open
OneAvargeCoder193 wants to merge 3 commits intoPixelGuys:masterfrom
Open
add renderBlock but not ancient#2884OneAvargeCoder193 wants to merge 3 commits intoPixelGuys:masterfrom
OneAvargeCoder193 wants to merge 3 commits intoPixelGuys:masterfrom
Conversation
Contributor
Author
|
i also did the thing quanturm asked which was to have it use a function instead of calculating it manually |
IntegratedQuantum
requested changes
Apr 19, 2026
Member
IntegratedQuantum
left a comment
IntegratedQuantum
left a comment
There was a problem hiding this comment.
This is too big. Could you please split it into smaller steps so it's easier to follow and has less conflict potential? Rendering stuff is something that I would like to put more work into for #102
I'd suggest:
1 PR that just moves what's in graphics to a separate function in renderer
1 PR that introduces the getLight function
1 PR that adds the modelMatrix to the shaders and stuff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lets you render blocks with model matrices