Allow enabling/disabling item drops based on tool type#2886
Allow enabling/disabling item drops based on tool type#2886IntegratedQuantum merged 10 commits intoPixelGuys:masterfrom
Conversation
Welcome to Cubyz! And with adding the possibility to specify multiple tags we still allow for the possibility to add such grouping tags as you mentioned |
|
Good point! I'll change it :) |
Wunka
left a comment
There was a problem hiding this comment.
Now you need to wait for quantum to review.
|
Thankss, more for the pile 😈 |
|
Hiii Quantum, thanks for the review! I've fixed the points :) |
IntegratedQuantum
left a comment
There was a problem hiding this comment.
Thanks for working on this, please next up actually add it to the plants so we can finally get rid of all the undesired inventory clutter
|
Thankss Quantum! I'll make a new PR :) |
Hiiii, love this project! :D Resolves PixelGuys#856 Opens up PixelGuys#1558, PixelGuys#2384 and PixelGuys#2787 Adds two new optional tags to item drops: - `.forbiddenToolTags`: Using a tool with any of these tags won't drop the item - `.allowedToolTags`: The item is only dropped when using a tool with any of these tag Forbidden has preference over allowed The only disadvantage I could think of with this approach is that you can't match the hand, or the combination hand + a tool, because the hand is treated as "no tool", it doesn't have a tag. But I couldn't think of any use cases for that anyway, so it might be fine! ~~I've changed leaves for easy testing (apples only drop by hand, and leaves only drop by sickle). I'll change it back when the approach is greenlit :3~~ Removed the testing config
Hiiii, love this project! :D
Resolves #856
Opens up #1558, #2384 and #2787
Adds two new optional tags to item drops:
.forbiddenToolTags: Using a tool with any of these tags won't drop the item.allowedToolTags: The item is only dropped when using a tool with any of these tagForbidden has preference over allowed
The only disadvantage I could think of with this approach is that you can't match the hand, or the combination hand + a tool, because the hand is treated as "no tool", it doesn't have a tag. But I couldn't think of any use cases for that anyway, so it might be fine!
I've changed leaves for easy testing (apples only drop by hand, and leaves only drop by sickle). I'll change it back when the approach is greenlit :3Removed the testing config