Fix control binding the escape key.#2896
Open
HansAschenloher wants to merge 1 commit intoPixelGuys:masterfrom
Open
Fix control binding the escape key.#2896HansAschenloher wants to merge 1 commit intoPixelGuys:masterfrom
HansAschenloher wants to merge 1 commit intoPixelGuys:masterfrom
Conversation
When pressing the escape key while in a control binding process, then the control should get bound to escape and the settings window should still be open. This commit disables closing the settings window while binding a key. fixes: PixelGuys#2257
IntegratedQuantum
requested changes
Apr 19, 2026
Member
IntegratedQuantum
left a comment
IntegratedQuantum
left a comment
There was a problem hiding this comment.
The same issue applies to all other keybinds that can be pressed while in the settings.
So please apply this fix in a central location where it applies to all keybinds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When pressing the escape key while in a control binding process, then the control should get bound to escape and the settings window should still be open.
This commit disables closing the settings window while binding a key.
fixes: #2257