[AAA] Part 3 Item callbacks by Wunka · Pull Request #2898 · PixelGuys/Cubyz

Wunka · 2026-04-12T17:32:11Z

This PR will add ItemCallbacks
For now this will only contain onLeftClick

Requires: #2891

What needs to be done before this PR is ready:

add the execution of the callback at all relevant places
move breaking of blocks in a callback
move special wand mechanic into a callback
remove testing callback

Wunka · 2026-04-14T07:57:00Z

@Argmaster I will have to look over the code again to remove some things like the temporary zon creation. But I would like your input for the general structure atleast.

Argmaster · 2026-04-14T19:34:13Z

-	damage: f32,
+	properties: [@typeInfo(ProceduralItemProperty).@"enum".fields.len]f32 = @splat(0),

 	durability: u32,


I think we should consider replacing durability field with timesUsed or something alike, basically reversed durability, so when a tool gets balance changes it doesn't show up funny. Would have to be clamped at zero and tool with zero durability would have to break instantly.

ofc out of scope

Wouldn't that mean that for example if a player has an item wich has like 300 timesUsed and we reduce through an update the maxUsage to something below 300, then the item would just break instantly on joining the world.

We break items only when they are used.
But yes, general intention is to make the item asap.

Argmaster · 2026-04-14T19:40:33Z

 		};
 	}
+
+	pub fn onLeftClick(self: Item) ItemUsedCallback {


I think I would prefer if we followed the pattern we used before where Item functions only call into identical functions of ProceduralItem and BaseItem. This guarantees that when implementations diverge, changes will be limited to those structs.
Its a bit more explicit, but I think its for a good reason.

is that not what I am already doing? The only wierd thing is the null but for that I have to fallback to the default behavior

I would expect

.baseItem => |item| item.onLeftClick(),

And call into callback inside impl of onLeftClick
Not sure tho, I had a look at other implementations after making this comment and they are not that consistent.

Ah. I understand now. Yeah its not consistent, but I will change it.

Argmaster · 2026-04-14T19:59:11Z

+	item: main.items.Item,
+	target: union(enum) {
+		block: struct { block: Block, blockPos: Vec3i },
+		entity: *main.server.Entity,


I think these may not be mutually exclusive.
A scythe, or a large axe may do AOE damage, what then? (Hitting multiple blocks or entities and blocks)
Should we even do that inside the callback or outside of it?
Additionally it may be very useful to get the source player as a parameter and source inventory too.
Although that last thing has no use for now, so that's something to ignore for now.

Honestly I would remove the target completely and instead provide tools to query the possible target from MeshSelection if the callback cares to do so. This means the params need to be extended with everything required for such query.

Argmaster · 2026-04-14T20:04:48Z

 	}

-	pub fn breakBlock(inventory: main.items.Inventory.ClientInventory, slot: u32, deltaTime: f64) void {
+	pub fn breakBlock(inventory: main.items.Inventory.ClientInventory, slot: u32, _deltaTime: f64) void {


I think you should eliminate the chain of jumps before this call.
Currently you are jumping game.breakBlock -> Inventory.breakBlock -> renderer.MeshSelection.breakBlock -> <onLeftClick callback> for no reason IMO I think it should just call left click callback directly from game.breakBlock.

Argmaster · 2026-04-14T20:06:07Z

-	pub fn breakBlock(inventory: main.items.Inventory.ClientInventory, slot: u32, deltaTime: f64) void {
+	pub fn breakBlock(inventory: main.items.Inventory.ClientInventory, slot: u32, _deltaTime: f64) void {
+		var deltaTime = _deltaTime;
 		if (selectedBlockPos) |selectedPos| {


I think breaking animation should be handled inside the callback. You may want to extract it as helper function, but it should be called from inside the callback. There might be tools that don't remove breaking animation.

that means callbacks would need a finsish method right? How would they else know that the they can remove the animation

No? I think no.
This is clearing braking animation when you start braking different block.
Since this callback calls into updateBlock sync call, you can do stuff before and after it too, so you can also clear it after brekitn a block.

Argmaster · 2026-04-14T20:08:29Z

 	var selectionFace: chunk.Neighbor = undefined;
 	var lastPos: Vec3d = undefined;
-	var lastDir: Vec3f = undefined;
+	pub var lastDir: Vec3f = undefined;


I don't think it should be made public; ~~this should be a parameter to callback. Preferably inside a struct alongside lastPos as playerOrientation or alike.~~ Callback should receive current player position and direction and should figure out storing that. Then the callback should figure out storing that, no?

Argmaster · 2026-04-14T20:14:24Z

 	}

-	fn updateBlockAndSendUpdate(source: main.items.Inventory.ClientInventory, slot: u32, pos: Vec3i, oldBlock: blocks.Block, newBlock: blocks.Block) void {
+	pub fn updateBlockAndSendUpdate(source: main.items.Inventory.ClientInventory, slot: u32, pos: Vec3i, oldBlock: blocks.Block, newBlock: blocks.Block) void {


No you don't. This function makes no sense as part of public API of renderer. Renderer does rendering, it doesn't send updates. Move it or call executeCommand.

Argmaster · 2026-04-14T20:15:12Z

-	var currentBlockProgress: f32 = 0;
-	var currentSwingProgress: f32 = 0;
-	var currentSwingTime: f32 = 0;
+	pub var lastSelectedBlockPos: Vec3i = undefined;


This should be managed by callback implementation IMO. MeshSelection may have its own use cases for it (does it?) but even then it shouldn't share it with everyone.

Wunka added 10 commits April 12, 2026 13:01

move properties to array

55cdb55

remove mass

17571af

use getProperty and getPropertyPtr

8c4431c

didnt need that

47a1d20

fix order

ee84887

add onLeftClickCallback for items

69e32ba

remove prints

3925671

selection wand leftCLick

a987185

moves but still bugs

3e2675c

remove test callback

cba0b16

Wunka marked this pull request as ready for review April 13, 2026 19:33

Wunka changed the title ~~[AAA] Item callbacks~~ [AAA] Part 3 Item callbacks Apr 13, 2026

Argmaster self-requested a review April 14, 2026 08:09

Argmaster reviewed Apr 14, 2026

View reviewed changes

Argmaster mentioned this pull request Apr 18, 2026

Add onBlockUpdate callback to modifiers and items #2892

Open

Wunka added this to PRs to review Apr 19, 2026

Wunka moved this to WIP/not ready for review in PRs to review Apr 19, 2026

Uh oh!

Conversation

Wunka commented Apr 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Wunka commented Apr 14, 2026

Uh oh!

Argmaster Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Argmaster Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Argmaster Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Argmaster Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Argmaster Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Argmaster Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Wunka commented Apr 12, 2026 •

edited

Loading

Argmaster Apr 14, 2026 •

edited

Loading

Argmaster Apr 14, 2026 •

edited

Loading

Argmaster Apr 14, 2026 •

edited

Loading

Argmaster Apr 15, 2026 •

edited

Loading

Argmaster Apr 14, 2026 •

edited

Loading

Argmaster Apr 14, 2026 •

edited

Loading