Add is_flipped_vertically flag to image loading#2922
Open
Argmaster wants to merge 2 commits intoPixelGuys:masterfrom
Open
Add is_flipped_vertically flag to image loading#2922Argmaster wants to merge 2 commits intoPixelGuys:masterfrom
is_flipped_vertically flag to image loading#2922Argmaster wants to merge 2 commits intoPixelGuys:masterfrom
Conversation
IntegratedQuantum
requested changes
Apr 19, 2026
| return result; | ||
| } | ||
| pub fn readUnflippedFromFile(allocator: NeverFailingAllocator, path: []const u8) !Image { | ||
| pub fn readFromFile(allocator: NeverFailingAllocator, path: []const u8, options: struct { is_flipped_vertically: bool = false }) !Image { |
Member
There was a problem hiding this comment.
Suggested change
| pub fn readFromFile(allocator: NeverFailingAllocator, path: []const u8, options: struct { is_flipped_vertically: bool = false }) !Image { | |
| pub fn readFromFile(allocator: NeverFailingAllocator, path: []const u8, options: struct { isFlippedVertically: bool = true }) !Image { |
Also previous default was true, since OpenGL wants them flipped.
Collaborator
Author
There was a problem hiding this comment.
The default was true, but logically it is not what you expect.
Collaborator
Author
There was a problem hiding this comment.
We can add alias readFromFileOpenGl or something that by default flips the image.
Member
There was a problem hiding this comment.
Maybe an enum would be better?
Collaborator
Author
There was a problem hiding this comment.
const Orientation = enum {
asIs,
openGl,
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So, I usually say that flags are bad, but they are not that bad, to duplicate whole function body :)))