Open
Conversation
IntegratedQuantum
requested changes
Apr 19, 2026
Member
IntegratedQuantum
left a comment
IntegratedQuantum
left a comment
There was a problem hiding this comment.
Bad news: It still breaks sometimes, as you can see I spawned a ball on the left, but some particles phased through the rocks, and reappeared in small groups on the right:
| inline for (0..3) |j| { | ||
| const move = particleLocal.velAndRotationVel[j]*deltaTime; | ||
| if (main.game.collision.collides(.client, @enumFromInt(j), move, v3Pos, hitBox)) |box| { | ||
| const skin = 0.0001; |
Member
There was a problem hiding this comment.
I did remove that from the other collision functions a while ago because it was causing different issues.
For particles we do however need them (unless we go fixed-point) due to accuracy loss when doing the relative-player coordinate thing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
there is still an issue if particles spawn inside the block, but i think that should be solved in a different pr