Skip to content

Feat: import sites groups - #593

Open
IdrissaD wants to merge 32 commits into
PnX-SI:developfrom
naturalsolutions:feat/import-sites-groups-new
Open

Feat: import sites groups#593
IdrissaD wants to merge 32 commits into
PnX-SI:developfrom
naturalsolutions:feat/import-sites-groups-new

Conversation

@IdrissaD

@IdrissaD IdrissaD commented Mar 19, 2026

Copy link
Copy Markdown
Contributor

Fixes #574

  • ajout d'une colonne id_import à TMonitoringSitesGroups
  • ajout des groupes de sites à la logique d'import sur un modèle similaire aux sites et visites
  • gestion du fait qu'il peut y avoir des sites sans parent (certains protocoles ont des sites mais pas de groupes de sites)
  • écriture des tests, dont :
    • groupes de sites avec sites
    • groupes de sites seuls
    • sites sans groupes de sites
    • sites avec groupes de sites déjà existants
    • réimport du même fichier
    • vérification des altitudes, géométries
    • suppression d'un import

@IdrissaD
IdrissaD force-pushed the feat/import-sites-groups-new branch from eaaaca6 to 72bae4d Compare March 19, 2026 11:37
@codecov

codecov Bot commented Mar 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.65471% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.92%. Comparing base (d148f12) to head (9cd4880).
⚠️ Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
...le_monitoring/monitoring/import_actions/actions.py 98.57% 1 Missing ⚠️
...nitoring/monitoring/import_actions/site_actions.py 97.14% 1 Missing ⚠️
...g/monitoring/import_actions/sites_group_actions.py 98.82% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #593      +/-   ##
===========================================
+ Coverage    80.72%   81.92%   +1.20%     
===========================================
  Files           46       47       +1     
  Lines         3741     3940     +199     
===========================================
+ Hits          3020     3228     +208     
+ Misses         721      712       -9     
Flag Coverage Δ
pytest 81.92% <98.65%> (+1.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@IdrissaD
IdrissaD marked this pull request as ready for review March 19, 2026 15:52
@IdrissaD
IdrissaD force-pushed the feat/import-sites-groups-new branch from 72bae4d to 16731f6 Compare July 20, 2026 18:24
@IdrissaD
IdrissaD marked this pull request as draft July 21, 2026 10:49
IdrissaD added 7 commits July 22, 2026 10:36
…void empty visit dataframe crash and site constant-field identification, parent error cascades, flush before decode in re-import helper)
…nal (same file as the mandatory test, default config)
…ites group instead of silently importing the site without group
…nstead of a local helper and translate fix comments to english
@IdrissaD
IdrissaD marked this pull request as ready for review July 22, 2026 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant