Skip to content

Nomenclature : add _label_xxx properties on upsert - #672

Open
amandine-sahl wants to merge 5 commits into
refact-configfrom
refact/duplicate_nomenclature
Open

Nomenclature : add _label_xxx properties on upsert#672
amandine-sahl wants to merge 5 commits into
refact-configfrom
refact/duplicate_nomenclature

Conversation

@amandine-sahl

Copy link
Copy Markdown
Contributor

@amandine-sahl
amandine-sahl force-pushed the refact/duplicate_nomenclature branch from b479e90 to 8bb6766 Compare August 10, 2026 15:12
@codecov

codecov Bot commented Aug 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.81%. Comparing base (78b07e7) to head (123976f).

Files with missing lines Patch % Lines
backend/gn_module_monitoring/monitoring/schemas.py 80.00% 1 Missing ⚠️
...kend/gn_module_monitoring/monitoring/serializer.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           refact-config     #672      +/-   ##
=================================================
- Coverage          80.31%   79.81%   -0.50%     
=================================================
  Files                 48       48              
  Lines               4211     4207       -4     
=================================================
- Hits                3382     3358      -24     
- Misses               829      849      +20     
Flag Coverage Δ
pytest 79.81% <90.00%> (-0.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@amandine-sahl
amandine-sahl force-pushed the refact/duplicate_nomenclature branch from 2c27419 to 123976f Compare August 12, 2026 15:39
JOIN ref_nomenclatures.t_nomenclatures tn
ON tn.id_nomenclature::text = v.id_nomenclature
) lbl ON e.jkey = ANY(:fields_list)
GROUP BY tsc.id_observation , tsc.data

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

group by id_observation_detail ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants