Added proper detection for gmax and tera type#1214
Merged
Mysticial merged 7 commits intoPokemonAutomation:mainfrom Apr 30, 2026
Merged
Added proper detection for gmax and tera type#1214Mysticial merged 7 commits intoPokemonAutomation:mainfrom
Mysticial merged 7 commits intoPokemonAutomation:mainfrom
Conversation
Collaborator
|
Is this stuff specific to Home? Or in general? Since a lot of the type detector logic is copy-pasted from the Sword/Shield one? So if this is generic (the type symbols are the same), we can merge that. If it's not and these are specific to Home, then you should move these into the Pokemon Home directory. |
Member
Author
|
I put it in the same class as the detection logic was the same, just using different sprite resources. These icons are very similar to the ones on the map in SV. However, after some testing they appear to be different enough to cause miss-reads. Moved tera detection to home inference folder. Updated the resource location as these are Home specific. PokemonAutomation/Packages#57 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the following issue:
TODO: gmax symbol is at the same location as Tera type symbol! Need better detection to tell apart
Tera types were causing false positives for Gmax. Breaking the living dex sorter.
Added template matching for Gigantamax
Added call to TypeReader for Tera types
Support sorting by Tera type