Skip to content

Added proper detection for gmax and tera type#1214

Merged
Mysticial merged 7 commits intoPokemonAutomation:mainfrom
Dalton-V:home-gmax-tera-detection
Apr 30, 2026
Merged

Added proper detection for gmax and tera type#1214
Mysticial merged 7 commits intoPokemonAutomation:mainfrom
Dalton-V:home-gmax-tera-detection

Conversation

@Dalton-V
Copy link
Copy Markdown
Member

@Dalton-V Dalton-V commented Apr 26, 2026

Resolves the following issue:
TODO: gmax symbol is at the same location as Tera type symbol! Need better detection to tell apart
Tera types were causing false positives for Gmax. Breaking the living dex sorter.

Added template matching for Gigantamax
Added call to TypeReader for Tera types

Support sorting by Tera type

  • Test Gmax Detection
  • Test Tera Detection

@Dalton-V Dalton-V mentioned this pull request Apr 26, 2026
8 tasks
@Dalton-V Dalton-V marked this pull request as ready for review April 28, 2026 03:33
@Mysticial
Copy link
Copy Markdown
Collaborator

Is this stuff specific to Home? Or in general? Since a lot of the type detector logic is copy-pasted from the Sword/Shield one? So if this is generic (the type symbols are the same), we can merge that. If it's not and these are specific to Home, then you should move these into the Pokemon Home directory.

@Dalton-V
Copy link
Copy Markdown
Member Author

I put it in the same class as the detection logic was the same, just using different sprite resources. These icons are very similar to the ones on the map in SV. However, after some testing they appear to be different enough to cause miss-reads.

Moved tera detection to home inference folder. Updated the resource location as these are Home specific. PokemonAutomation/Packages#57

@Mysticial Mysticial merged commit fb8c385 into PokemonAutomation:main Apr 30, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants