update show_update_nag()#1227
Closed
jw098 wants to merge 1 commit intoPokemonAutomation:mainfrom
Closed
Conversation
Collaborator
Author
|
I missed the fact that skip_version is a string, and not a number that can be compared. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the logic to cover for the case where your current version is behind both the public and private beta version.
In this case, "Skip this version" doesn't work since the saved version to skip will alternate between the public and private beta version number. e.g. If your current version number is 0.63.7, the pop-up will alternate between 0.63.8 (the beta) and 0.63.9 (public release).