Skip to content

Cram-o-matic: Increase wait time between dialog checks #1247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mysticial merged 2 commits into from
May 16, 2026
Merged

Cram-o-matic: Increase wait time between dialog checks #1247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
480c98c
fix physical orbeetle attack debug images being saved twice
fyex May 16, 2026
66c712d
add config option for wait time between checking the receive dialog
fyex May 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...Programs/Source/PokemonSwSh/Inference/RNG/PokemonSwSh_OrbeetleAttackAnimationDetector.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ OrbeetleAttackAnimationDetector::Detection OrbeetleAttackAnimationDetector::run(
return Detection::SPECIAL;
}
if (save_screenshot){
animation_image->save("orbeetle-attack-physical-" + now_to_filestring() + ".png");
//animation_image->save("orbeetle-attack-physical-" + now_to_filestring() + ".png");
dump_debug_image(m_stream.logger(), "rng", "orbeetle-physical", animation_image);
}
m_stream.log("Orbeetle Attack Animation: Physical animation detected.");
Expand Down
10 changes: 9 additions & 1 deletion SerialPrograms/Source/PokemonSwSh/Programs/RNG/PokemonSwSh_CramomaticRNG.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,13 @@ CramomaticRNG::CramomaticRNG()
LockMode::LOCK_WHILE_RUNNING,
"80 ms"
)
, DIALOG_RELEASE_DURATION(
"<b>Dialog Release Duration:</b><br>"
"After releasing the button, wait this long before checking the dialog.<br>"
"<font color=\"red\">For tick-imprecise controllers, this number will be increased automatically.</font>",
LockMode::LOCK_WHILE_RUNNING,
"1840 ms"
)
, SAVE_SCREENSHOTS(
"<b>Save Debug Screenshots:</b>",
LockMode::LOCK_WHILE_RUNNING,
Expand Down Expand Up @@ -174,6 +181,7 @@ CramomaticRNG::CramomaticRNG()
PA_ADD_OPTION(MAX_UNKNOWN_ADVANCES);
PA_ADD_OPTION(ADVANCE_PRESS_DURATION);
PA_ADD_OPTION(ADVANCE_RELEASE_DURATION);
PA_ADD_OPTION(DIALOG_RELEASE_DURATION);
PA_ADD_OPTION(SAVE_SCREENSHOTS);
PA_ADD_OPTION(LOG_VALUES);
}
Expand Down Expand Up @@ -348,7 +356,7 @@ std::pair<bool, std::string> CramomaticRNG::receive_ball(SingleSwitchProgramEnvi

while (presses < 30 && !arrow_detected){
presses++;
pbf_press_button(context, BUTTON_B, 80ms, 1320ms);
pbf_press_button(context, BUTTON_B, 80ms, DIALOG_RELEASE_DURATION);
context.wait_for_all_requests();

VideoSnapshot screen = env.console.video().snapshot();
Expand Down
1 change: 1 addition & 0 deletions SerialPrograms/Source/PokemonSwSh/Programs/RNG/PokemonSwSh_CramomaticRNG.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ class CramomaticRNG : public SingleSwitchProgramInstance{
SimpleIntegerOption<uint16_t> MAX_UNKNOWN_ADVANCES;
MillisecondsOption ADVANCE_PRESS_DURATION;
MillisecondsOption ADVANCE_RELEASE_DURATION;
MillisecondsOption DIALOG_RELEASE_DURATION;
BooleanCheckBoxOption SAVE_SCREENSHOTS;
BooleanCheckBoxOption LOG_VALUES;

Expand Down
Loading