[codex] Honor explicit economy dataset selection#3380
Draft
[codex] Honor explicit economy dataset selection#3380
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3380 +/- ##
==========================================
+ Coverage 72.20% 72.24% +0.03%
==========================================
Files 56 56
Lines 2425 2428 +3
Branches 423 424 +1
==========================================
+ Hits 1751 1754 +3
Misses 595 595
Partials 79 79 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
enhanced_cps,cps, andenhanced_frsbefore falling back to the regional default dataset._setup_data()and at theSimulationOptionslayer.maketargets for fresh worktrees and PR preflight (bootstrap-dev,lint,check-changelog,pre-pr,ci).README.mdandCLAUDE.mdso fresh sessions default touv/makerather than ad hoc.venv/bin/...commands.Why
The economy API accepted a
datasetquery param from the web app, but_setup_data()ignored most named datasets and silently usedget_default_dataset(...)instead. That meant the UI could present a non-default dataset selection while the backend still scored the default dataset.Separately, the initial PR follow-up hit avoidable worktree drift because local commands depended on implicit tool paths instead of repo-native commands. This PR now encodes the intended workflow directly in the repo and CI.
Impact
defaultbehavior and the specialnational-with-breakdownspassthrough datasets are unchanged.make bootstrap-devandmake pre-prwithout assuming a specific shell-local tool path layout.Validation
make pre-prmake test-env-varsin a configured environment