Skip to content

Add statefip (FIPS code) input support#803

Open
PavelMakarchuk wants to merge 3 commits intomainfrom
add-statefip-support
Open

Add statefip (FIPS code) input support#803
PavelMakarchuk wants to merge 3 commits intomainfrom
add-statefip-support

Conversation

@PavelMakarchuk
Copy link
Copy Markdown
Collaborator

Summary

  • Adds statefip as a recognized input column (FIPS codes)
  • When statefip is provided and state is 0 or missing, automatically converts FIPS→SOI
  • Matches TAXSIM-35 behavior (x(55)ifip2irs conversion)
  • Prevents users from accidentally passing FIPS codes in the state column and getting wrong state results (e.g., FIPS 48=Texas interpreted as SOI 48=Washington)

Test plan

  • All 98 existing tests pass
  • Verified FIPS 48 (TX) → SOI 44, FIPS 12 (FL) → SOI 10, FIPS 6 (CA) → SOI 5
  • State EITC correctly returns 0 for TX and FL when using statefip

🤖 Generated with Claude Code

PavelMakarchuk and others added 2 commits March 30, 2026 20:11
…efundable portions

Previously v22 mapped to ctc_value (total CTC) and v23 was unimplemented.
Per TAXSIM-35 docs, v22 is "Child Tax Credit (as adjusted)" (nonrefundable)
and v23 is "Additional Child Tax Credit" (refundable).

Now: v22 → non_refundable_ctc, v23 → refundable_ctc.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…le and refundable portions"

This reverts commit 5eb5fb7.
@vercel
Copy link
Copy Markdown

vercel bot commented Mar 31, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
policyengine-taxsim Ready Ready Preview, Comment Mar 31, 2026 10:38am

Request Review

TAXSIM-35 accepts both SOI codes (state column) and FIPS codes
(statefip column). When statefip is provided and state is 0 or
missing, automatically convert FIPS→SOI. This prevents users from
accidentally passing FIPS codes in the state column and getting
wrong state tax results.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant