Sum person-level variables to tax-unit level in state output resolver#815
Merged
PavelMakarchuk merged 3 commits intomainfrom Apr 6, 2026
Merged
Sum person-level variables to tax-unit level in state output resolver#815PavelMakarchuk merged 3 commits intomainfrom
PavelMakarchuk merged 3 commits intomainfrom
Conversation
Fixes #814. Some state variables (e.g., mt_eitc, mt_elderly_homeowner_or_renter_credit, co_family_affordability_credit) are defined at the Person entity level in policyengine-us. For joint or family households with multiple persons, the returned array shape mismatched the expected tax-unit-level shape, causing a ValueError. Now detects when a calculated array is longer than expected and sums person values to produce the tax-unit aggregate. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Strengthens regression coverage for issue #814 by testing code paths that directly exercise the person-to-tax-unit summing: - CO sctc: co_family_affordability_credit (Person, per-child) - MO v36: mo_taxable_income (Person, separate filing) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ValueErrorfor joint/family filers in states with Person-level credit variables (MT, CO)Closes #814
Affected variables
mt_eitcmt_elderly_homeowner_or_renter_creditco_family_affordability_creditTest plan
_try_calculate_variableaggregationexport_household🤖 Generated with Claude Code