Parameterise VAT rate and ETB year in VAT imputation#354
Merged
Conversation
Contributor
Author
|
Self-review: APPROVE. See |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
datasets/imputations/vat.pyhardcoded three values that will drift:CONSUMPTION_PCT_REDUCED_RATE = 0.03("from OBR's VAT page" with no URL or year).CURRENT_VAT_RATE = 0.2— "current" will not stay current.etb.year == 2020inline, with no way to rebuild on 2021 data that's already in the ETB file.This PR:
_get_vat_parameters(year)which reads the standard rate and reduced-rate share frompolicyengine_uk.parameters.gov.hmrc.vatkeyed on year. Falls back to aVAT_RATE_BY_YEARmodule dict and ultimately the statutory 2020 values so offline test environments still work.yearargument (andDEFAULT_ETB_YEAR = 2020constant) ongenerate_etb_tableandsave_imputation_models.vat.pklstays fingerprint-compatible unless retrained.Adds
test_vat_parameters.pycovering the parameter lookup, the module fallback, the year-filtering kwarg, and the rate sensitivity of the computedfull_rate_vat_expenditure_rate.Test plan
uv run pytest policyengine_uk_data/tests/test_vat_parameters.py -qpasses.Finding U7 from the bug hunt.