Remove legacy test_changelog_encoding.py#360
Merged
Conversation
The test validated UTF-8 and YAML structure of the deprecated `changelog_entry.yaml`. That file was retired when the repo migrated to towncrier `changelog.d/` fragments; all three tests now unconditionally `pytest.skip` because the file no longer exists, and any fragment-format validation is already handled by the PR CI's `Check changelog fragment` step. Also deletes one more on-tree mention of the old format, so nobody (human or AI agent) rediscovers it from code search and assumes it's the current path. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
policyengine_uk_data/tests/test_changelog_encoding.pyvalidated UTF-8 and YAML structure of the deprecatedchangelog_entry.yaml. That file was retired when the repo migrated to towncrierchangelog.d/fragments; all three tests now unconditionallypytest.skipbecause the file no longer exists, and any fragment-format validation is already handled by the PR CI'sCheck changelog fragmentstep.Also deletes one more on-tree mention of the old format so nobody (human or AI agent) rediscovers it from code search and assumes it's still current.
Part of a sweep across PolicyEngine repos (PolicyEngine/policyengine-uk#1629, PolicyEngine/policyengine-core#476, PolicyEngine/policyengine-us#8061).
Test plan
pytest.skipno-ops