Conversation
Collaborator
Author
baogorek
approved these changes
Apr 7, 2026
Collaborator
baogorek
left a comment
There was a problem hiding this comment.
Looks good — the core fix is correct and towncrier check --compare-with origin/main is the right replacement for the naive file count.
Two minor notes (not blocking):
-
553.md and 589.md are unconsumed — their text never made it into CHANGELOG.md despite multiple version bumps since they were added. Deleting them won't break anything, but those changelog entries will be lost permanently. They also don't need to be deleted for the fix to work, since
towncrier check --compare-with origin/mainonly looks at the diff. -
uv sync --devis heavy for this job — it installs the full dev dependency tree just to runtowncrier. Something likepip install towncrier>=24.8.0oruvx towncrier checkwould be faster.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #698
Summary
Test plan