Require head/spouse for NJ CCAP activity eligibility#8073
Merged
MaxGhenis merged 1 commit intoPolicyEngine:mainfrom Apr 18, 2026
Merged
Require head/spouse for NJ CCAP activity eligibility#8073MaxGhenis merged 1 commit intoPolicyEngine:mainfrom
MaxGhenis merged 1 commit intoPolicyEngine:mainfrom
Conversation
Follow-up to PolicyEngine#7811. nj_ccap_activity_eligible treated an SPM unit with zero heads/spouses as satisfying the activity test: n_qualifying (0) >= n_parents (0) evaluates to True. A unit composed only of dependents would therefore vacuously pass. Require at least one head/spouse to be present (n_parents >= 1) alongside the existing "every head/spouse must independently qualify" rule from N.J.A.C. 10:15-5.2. Adds a dedicated nj_ccap_activity_eligible.yaml test suite, including a regression case with only dependents. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8073 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 18 1 -17
Lines 353 23 -330
Branches 4 0 -4
==========================================
- Hits 353 23 -330
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #7811.
nj_ccap_activity_eligibletreated an SPM unit with zero heads/spouses as satisfying the activity test:n_qualifying (0) >= n_parents (0)evaluates toTrue. A unit composed only of dependents would vacuously pass.This adds
n_parents >= 1to the head/spouse qualification rule from N.J.A.C. 10:15-5.2, matching the fix applied to SC CCAP activity eligibility.Changes
policyengine_us/variables/gov/states/nj/njdhs/ccap/eligibility/nj_ccap_activity_eligible.py: requiren_parents >= 1alongsiden_qualifying >= n_parents.nj_ccap_activity_eligible.yamltest suite covering work hours, student exemption, multi-parent gating, and the orphaned-minors regression case.Test plan
Case 5, SPM unit with only dependents) fails before the fix and passes after.policyengine_us/tests/policy/baseline/gov/states/nj/pass.