test(perf): increase Trino worker execution concurrency - #1163
Merged
Conversation
Test Impact PlanDeterministic summary of how this PR changes tests, CI runners, and coverage-risk signals. Summary
Signals
Coverage risk: neutral or increased No coverage-reduction warnings detected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow up on the completed experiment in #1162, closed without merging its shape-selection code. Start from
mainand change only the isolated Trino test lane's worker execution concurrency:task.max-worker-threads=8andtask.min-drivers=16per worker, 4x the pinned engine's expected one-CPU defaults of 2 and 4.task.concurrencyunchanged.The shared isolated manifest is used by both Trino E2E and frozen perf. Shared and production deployments are unaffected.
Motivation
The four-shape benchmark showed little benefit from consolidation at equal resources and approximately 2x throughput at twice the worker budget. Historical CPU usage during exact distinct was around 48-56% of quota. The experiment increased both resources and CPU-derived concurrency, so it did not isolate a CPU or storage bottleneck.
This change tests whether additional overlapping scan work improves latency at the original resource budget.
task.min-driversis a leaf-driver target, not a hard limit or an S3 request count. Higher concurrency can also increase heap pressure and context switching; no performance improvement is claimed before validation.Validation
go test -count=1 ./tests/mw-dev ./tests/perf/publisherclipassed.just test-scenariopassed.git diff --checkpassed; independent review found no actionable issues.just lintreports six existing SA4023 diagnostics in unchanged control-plane code; reproduced on based7e852d8. Changed-code lint (golangci-lint run --new-from-rev=origin/main) passed.Run the existing benchmark on this branch and compare query medians, errors, memory pressure, and CPU behavior against the recorded baseline before merging: