fix(copy): raise CSV record limit to 64 MiB - #1164
Merged
Merged
Conversation
EDsCODE
marked this pull request as ready for review
September 9, 2026 12:23
Test Impact PlanDeterministic summary of how this PR changes tests, CI runners, and coverage-risk signals. Summary
Signals
Coverage risk: neutral or increased No coverage-reduction warnings detected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A billing sync now produces a valid CSV record slightly larger than Duckgres's hardcoded 10 MiB
MAX_LINE_SIZE, causing every Fivetran retry to fail during DuckDB parsing. Raise the limit to 64 MiB, document the new per-record maximum, and add a DuckDB-backed regression test that copies and verifies a single 11 MiB value.Validation:
Maximum line size of 10485760 bytes exceededjust test-unitjust lint(0 issues, run from an isolated clean worktree because unrelated untracked local Iceberg tests do not compile in the shared checkout)go test ./tests/integration -run '^TestCopyFromStdin' -count=1The complete integration package has a separate pre-existing failure outside this change; the COPY-focused integration tests pass.