add isForceSendFlag in param getFeatureFlag #319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marandaneto
reviewed
Nov 21, 2025
posthog-android/src/test/java/com/posthog/android/PostHogFake.kt
Outdated
Show resolved
Hide resolved
marandaneto
reviewed
Nov 21, 2025
marandaneto
reviewed
Nov 24, 2025
posthog-android/src/test/java/com/posthog/android/PostHogFake.kt
Outdated
Show resolved
Hide resolved
marandaneto
reviewed
Nov 24, 2025
marandaneto
reviewed
Nov 24, 2025
marandaneto
reviewed
Nov 24, 2025
marandaneto
reviewed
Nov 24, 2025
ioannisj
reviewed
Nov 25, 2025
Contributor
Author
|
will be more comments? @marandaneto @ioannisj |
ioannisj
reviewed
Nov 25, 2025
Collaborator
ioannisj
left a comment
ioannisj
left a comment
There was a problem hiding this comment.
LG to me but I'll let @marandaneto have a final look
Member
|
@KopeikinaDarya can you fix formatting and add a unit test for this? otherwise all good, thanks! |
marandaneto
reviewed
Nov 26, 2025
marandaneto
reviewed
Nov 26, 2025
marandaneto
reviewed
Nov 26, 2025
marandaneto
approved these changes
Nov 28, 2025
Member
|
@KopeikinaDarya please run |
added 2 commits
November 28, 2025 13:05
# Conflicts: # posthog-android/CHANGELOG.md
# Conflicts: # posthog/src/main/java/com/posthog/PostHog.kt
# Conflicts: # posthog-android/CHANGELOG.md
auto-merge was automatically disabled
December 2, 2025 12:41
Head branch was pushed to by a user without write access
Member
|
@KopeikinaDarya i will merge and release this asap, right now we are closed to contributor PRs due to https://posthog.com/blog/nov-24-shai-hulud-attack-post-mortem , should be back later this week or early next week |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the same problem wowrumal/posthog-ios#3
My change addresses the behavior of sticky feature flags from this PostHog tutorial. When initially reading and assigning feature flags to a user, I want to avoid sending the $feature_flag_called event, since these evaluations are not real exposures yet.
If I filter out these events using the beforeSend block, I lose all analytics related to feature flag exposures—including the ones I actually want to track. This approach also breaks experiment accuracy, because I can no longer trigger exposure events exactly when needed.
My update ensures that exposure events are sent only at the appropriate time, keeping experiment tracking reliable and analytics data clean.