Repository navigation
fix: Preserve Rust 1.78 dependency compatibility - #277
Merged
marandaneto merged 4 commits intoOct 6, 2026
Merged
Conversation
|
[High risk] Downgrades dependencies to support older Rust compiler. The PR should not merge until credentialed requests are protected against HTTPS-to-HTTP redirects with the locked Reqwest version. Reviews (2) · Last reviewed commit: "fix: Keep the locked dependency graph co..." |
Contributor
posthog-rs-v1 Compliance ReportDate: 2026-10-05 09:45:18 UTC ✅ All Tests Passed!111/111 tests passed Capture_V1 Tests✅ 94/94 tests passed View Details
Feature_Flags Tests✅ 17/17 tests passed View Details
|
Contributor
posthog-rs-v0 Compliance ReportDate: 2026-10-05 09:45:38 UTC ✅ All Tests Passed!46/46 tests passed Capture Tests✅ 29/29 tests passed View Details
Feature_Flags Tests✅ 17/17 tests passed View Details
|
marandaneto
marked this pull request as ready for review
October 5, 2026 09:36
dustinbyrne
approved these changes
Oct 5, 2026
marandaneto
deleted the
docs/refresh-agent-instructions-20261002-133550
branch
October 6, 2026 05:19
eli-r-ph
pushed a commit
that referenced
this pull request
Oct 12, 2026
* build: Correct minimum Rust version and refresh agent guidance * docs: Remove Rust minimum-version changes from instruction cleanup * fix: Keep the locked dependency graph compatible with Rust 1.78 * fix: Preserve MSRV when allowing atomic method deprecation (cherry picked from commit 26b75f2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Keep the SDK's declared Rust 1.78 minimum and verify it in CI. The previous lockfile selected dependencies that require newer Rust, so it could not build the SDK library on Rust 1.78.
The Rust minimum remains 1.78.0. The earlier compiler bump and its changeset have been removed.
The locked Reqwest 0.13.3 does not include the redirect and proxy credential fixes released in 0.13.4 and 0.13.5. The published dependency range still permits newer 0.13 releases for customers on newer Rust. This keeps the minimum-compatible graph available without imposing an upper version cap below those fixes.
💚 How did you test it?
d6c53b6358727a92380d7e028f7405e42a7342d5againstorigin/main.No runtime test source, fixtures, harnesses, or test discovery configuration changed. CI adds compiler checks. The only SDK source change is a statement-scoped deprecation allowance with its MSRV rationale. Runtime behavior and the public API snapshot are unchanged.
📝 Checklist
Existing runtime tests and new MSRV compilation checks cover this change. No changeset is included, as requested.
If releasing new changes
sampo addto generate a changeset fileThe earlier changeset was removed. This PR does not raise the compiler minimum.
Agent context
Autonomy: Human-driven (agent-assisted)
Tools: Pi, Git, GitHub CLI, Cargo, rustup, actionlint, TruffleHog, and isolated Pi autoreview. The human driver requested retaining Rust 1.78 support and allowing customers to resolve newer dependency versions. Compatibility was checked with actual compiler builds because dependency metadata alone missed async-compression's newer Rust syntax. Human review is still required. No public session link is available.