Repository navigation
Conversation
2 of 5 tasks
Covers the event ID rules, the $lib strip and the removed $lib_version parts, AI lane size limits, the C compiler need, retryable statuses and the no-hook log line, newly non-exhaustive types, and $debug_images. Adds changesets for capture_ai, the TLS features, the non-exhaustive types and the SDK identity header, and uses real per-event quota tags in test fixtures.
4 of 5 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
The 1.0 migration guide doesn't say how
$liband$lib_versionchange. On the V1 path, capture sets both from theposthog-sdk-infoheader (alwaysposthog-rs/<version>) and overwrites any value in the event. In 0.x,prepare_for_v0filled them only when missing, so a value set by the caller was kept.This PR adds an "SDK identity" section to
docs/migration-0.x-to-1.0.md. No code change. The SDK still sends a caller-set$lib, and PostHog overwrites it.The AI events paragraph and the
capture-ai-lanechangeset now say the immediate AI variants also drop an event over 8 MiB locally, which #286 implements.posthog-python 8.0 (PostHog/posthog-python#1034) and posthog-go v2 (PostHog/posthog-go#361) document the same rule: one SDK identity per client, set from the header.
💚 How did you test it?
Docs only. I checked the behavior in the source:
prepare_for_v0onmainkeeps an existing$lib, and onv1nothing insrc/adds or removes$lib(build_headers_sdk_info_is_canonical_lib_slash_versioncovers the header).📝 Checklist
If releasing new changes
sampo addto generate a changeset file🤖 Agent context
Autonomy: Human-driven (agent-assisted)