Sprint3 a&o#9
Open
AronFreyr wants to merge 11 commits into
Open
Conversation
This reverts commit d5f243e.
… around pdf2txt.py and dumppdf.py
PrimeNumb
requested changes
Oct 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made minor changes to the "split_by_chapters" function in pdf2txt.py in order to optimize it for speed.
Created more test cases for pdf2txt.
Made a special test file for memory and speed tests called "extra_time_and_memory_tests.py" but did not use the "test_" prefix in its name so that it would not run with the usual tests because they caused errors with the code coverage process.
Created extra tests for utilities.py to increase coverage.
Created extra tests for latin2ascii.py to increase coverage.
Fixed some bugs with pdf2txt. Biggest one was making sure that you could input a location for where the chapter files were supposed to be generated.
Added stuff to requirements.txt that was needed to test speed, memory and coverage.