Repository navigation
Fix GetAllServices<T>() for value-type services (#85) - #101
Merged
Merged
Conversation
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetAllServices() throws because the generic helper forwards through native non-generic enumeration, which requires reference-type covariance. Restore List aggregation with GetServices() and GetKeyedServices(), preserving authoritative snapshot keys, explicit enumerable precedence, multiplicity, AnyKey exclusion and private decoration-slot filtering.
Fixes #85.
Verification
Windows CI run 37631908863 passed for final head 1f44d35: 1,167 tests on each of net472/net8.0/net9.0/net10.0, plus all four native hot-cache checks. Checkout logs confirm the tested PR merge contains this exact head and develop 91c262e. Pack and Publish were skipped. This PR stays draft for human review.
Prepared with OpenAI Codex.
Co-authored-by: Codex codex@openai.com