Repository navigation
fix: apply precise framework interface filtering - #77
Merged
Merged
Conversation
Use ordinal System namespace boundaries and the exact mscorlib assembly name. Cover application assembly prefixes, namespace and case boundaries, and actual async disposal contracts across supported targets. Co-authored-by: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #60.
Systemnamespace, its child namespaces, or an assembly named exactlymscorlib, using ordinal case-sensitive comparisons.Systematic.Contractsand eliminate runtime-dependentIAsyncDisposableselection.Executed validation
d377a95ef0720d25b64da24a52ddfc30a5baec08(PR merge test commitdd90ab7693e0baf785baa23db611315803bbe4e5): 690/690 tests on each of net472/net8.0/net9.0/net10.0, plus all four native DI hot-cache runs. Logs confirm the real disposable-interface regression passes on every target, including Microsoft.Bcl.AsyncInterfaces on net472. Pack and Publish were correctly skipped.Prepared with OpenAI Codex.