Repository navigation
Fix diagnostic constructor selection parity (#88) - #94
Conversation
Keep ordinary type activation separate from DependsOn and decorator constructor rules. Add native-parity coverage for constructor ambiguity, attributes, contextual keys, optional defaults, constrained generics, lifetimes and ownership. Co-authored-by: Codex <codex@openai.com>
|
Test-first checkpoint for
The PR remains a draft. Cycle handling (#89), optimization work and release publishing are outside this change. Prepared with OpenAI Codex. |
|
Exact-head verification complete for Windows CI run 37440533272 succeeded. The job logs confirm 920/920 tests passed on each of net472, net8.0, net9.0 and net10.0, followed by four successful native hot-cache regressions (100 interleaved enumerations each after observed native compilation). Pack and Publish were skipped. After fetching the published head locally, the Release build, all three modern 920-test suites, and their hot-cache controls also passed again. The only build warnings are the two existing net472 dependency-support warnings. GitHub reports no merge conflicts. There are no submitted reviews or unresolved review threads at this checkpoint. This PR remains a draft for review; issue #88 has not been closed, and no subsequent issue work has started. Prepared with OpenAI Codex. |
Summary
Fixes #88.
ActivatorUtilitiesConstructoron ordinary type registrations, accept equivalent/permuted parameter sets, and reject shorter non-subset constructor ambiguity before activation.DependsOnmaps and decorator constructor selection on their existing paths.Test-first verification
developbaseline:335d3266ba5756af8230fd9a1ff64ce98375ba0c; 776 baseline tests passed on .NET 10.Scope
Cycle handling is tracked separately in #89. This change does not introduce recursive graph validation, optimize activation, change workflows, or publish a release. The PR remains a draft for review.
Prepared with OpenAI Codex.