Repository navigation
fix: preserve nullable structural collection elements - #40
Merged
Merged
Conversation
Guard nullable structural elements before object helpers, retaining nullable targets and nested collection input annotations without changing converter precedence. Fixes #26. Co-authored-by: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #26.
NullableMismatchPolicy.Throwbefore a non-null structural helper call, retaining the element path andInvalidOperationException. Keep the existingLITEMAPPER2003Error rejection and higher-precedence converter behavior.Test-first evidence
On unchanged develop
38e313ef836f9400dd0eeaea56d48ba35dca733d, the completed 31-case fixture produced 23 failures and eight passing controls, with no skips. The failures exposeNullReferenceExceptionand generatedCS8604warnings. The Collections sample independently failed at runtime.Coverage includes arrays, lists, enumerable/read-only targets, dictionary values, nested nullable collections, Error/Throw, count/order, single enumeration/getter evaluation, constructor suppression for nulls, Empty strategy independence, patch members, instance converters, recursive/shared references, C# 9 warning-free output, and determinism.
Local validation
2e3ba273489629c6b9605c728677554c0df442c1matches the tested local tree exactlyLocal limits and recovery
PowerShell and clang are unavailable. The final package command excludes 49 PowerShell-dependent cases. Trimming and Native AOT fail at ILLink's
ComputeManagedAssembliestask-host creation withMSB4216/ Unix-domainSocketException (13); local publish behavior is not established.An initial sample was separated into its own mapper to avoid unrelated declared-mapping selection. The package fixture's exact generated-file count was updated from five to six for the added mapper. An interrupted package attempt had no final TRX; the completed retry provides the results above. No diagnostic, assertion, dependency, prerequisite, or security setting was weakened.
CI and review
Ordinary exact-head CI run 37915931192 passed for
b509219f9a96f78417f9a6b59e8227c603556dec.The PR remains draft, mergeable, and awaiting human review. Work stops at this review checkpoint.
Draft for human review. No merge, release, tag, package publication, or workflow dispatch was performed.
Prepared with OpenAI Codex.