Repository navigation
fix: build cycle exception paths lazily - #46
Merged
Merged
Conversation
Retain an inline first segment and immutable ancestor links instead of copying full path prefixes on successful recursion. Preserve exact exception metadata, active-path cleanup, shallow allocation behavior, and portable generated code. Add allocation, runtime, sample, and package-consumer coverage. Fixes #32. Co-authored-by: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #32.
Test-first and allocation evidence
7b19def74753df90cb3770c7410ff5d7a3951244, the initial 13-case suite produced two failures and 11 passing controls, zero skips. The failures establish quadratic-prefix allocation and missing compact path storage; fixture inputs compile without unrelated errors.Local validation
Local environment limits
PowerShell and clang are absent; 49 PowerShell-dependent cases are unavailable locally. The established ILLink task-host socket restriction affects local trimming/Native AOT validation. No warning, assertion, dependency, prerequisite, credential, or security setting was weakened. The completed exact-head Windows/Linux and Roslyn CI below supplies the full-platform evidence.
Every uploaded blob and the remote tree matches the tested local source tree
4ff805481d91eb06d193eb1a890ea9ccd8213d2f.CI and review
Exact-head CI run 37949984701 passed for
c8585b2e700e0756168ebd6ed3e0931cf148d17e.This PR remains draft, mergeable, and stopped for human review. No merge, release, tag, NuGet publication, or workflow dispatch was performed. The previously documented nullable-intermediate enum defect is outside scope.
Prepared with OpenAI Codex.