Repository navigation
fix: preserve configured nullable updater overloads - #49
Merged
Merged
Conversation
Restore the selected nullable value type after configured patch captures. Add test-first regression, sample, package-consumer and documentation coverage. Fixes #47. Co-authored-by: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #47.
Test-first evidence
On unchanged develop
9c48bfd59fe586097ca18c4289c85f03e93e30bc, the completed new test matrix produced 20 failures and 9 passing controls, with all 38 previous capture tests passing and no skips. Failing runtime cases selected the non-nullable overload and produced sentinel 99 instead of 7, or violated returning-replacement semantics. The Basic sample independently failed its overload assertion.The first fixture iteration had one malformed external-container fixture; it was corrected before the final baseline. No production code or expected contract was changed to mask a failure.
Validation
b59af34a8d01760631e674768d52e2ae0e819291exactly matches the locally tested tree.Exact-head CI run #106 passed for
3a9c970aae8109c47a6051570935672c837e4895:b59af34a8d01760631e674768d52e2ae0e819291.Scoped work is ready for human review. This validation does not authorize merging or release.
Scope and risk
No public API, specification semantics, dependency, target framework, reflection, runtime dispatch or release workflow change. Null leaf/intermediate skipping, non-nullable leaf overloads, Source-only default selection, void/returning updaters, get-only mutation/writable replacement, instance/external receivers, changing getters, deterministic output, and sequential failure behavior are covered.
For human review. No merge, release, tag, NuGet publication or workflow dispatch was performed.
Prepared with OpenAI Codex.