Repository navigation
Fix nullable intermediate enum source paths - #50
Draft
AGiorgetti wants to merge 2 commits into
Draft
AGiorgetti wants to merge 2 commits into
AGiorgetti wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #48.
Test-first evidence
On unchanged production: 28 failures and 42 passing controls in the final 70-case enum fixture; the normally compiled Basic sample also reproduced the missing-path failure.
Four additional required nullable enum initializer cases failed the first candidate, while the explicit nullable-input converter control passed.
Final focused validation: 184 passed, zero failures or skips. Cases cover create/constructor/update/patch, by-name/by-value, known/unknown/null values, nullable leaves, reference paths followed by value/tuple fields, changing getters, stable exception metadata, numeric policy, converter precedence, and sequential update effects.
Initial CI exposed five Windows-only fixture failures caused by an LF-only insertion anchor. The follow-up uses the unique mapping attribute instead; all 75 enum cases pass with CRLF and the full 989-case generator suite passes after restoring LF. No assertions or production logic changed.
Local validation
CI and review boundary
Verified published head:
532a3b484d9c480ae9af1cd3a2d59f16fbb0c085; tree:bb19214ff83fac1b678f249fc03afc0597d3885amatches the locally validated tree. CI #109 completed successfully on this exact head. Its checked-out merge tree also matches the validated head tree.LITEMAPPER_REQUIRE_NATIVE_AOT=1, covering trimming, Native AOT, and the PowerShell-dependent cases unavailable locally. Linux sample/benchmark smoke and both solution-path checks passed.This draft is ready for human review. No merge, release, tag, NuGet publication, or workflow dispatch was performed.
Nullable value-type intermediate traversal that fails earlier source-path resolution is outside this enum-lowering repair.
Prepared with OpenAI Codex.