Repository navigation
fix: use default set comparer after element conversion - #52
Merged
Merged
Conversation
Classify the selected set element conversion before choosing a comparer. Preserve compatible comparers only for language identity and retain capability-based constructors. Add test-first generator, sample, package-consumer and documentation coverage. Fixes #51. Co-authored-by: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #51.
Test-first evidence
Unchanged baseline:
f7de4cf28ec63c2c3ac4c812cbdbe16502b2be62.Local validation
535fc13da48b23b9749c29e0f02eba25980c3c14.Coverage includes all four local/default/registered conversion stages across HashSet/ISet/IReadOnlySet, values distinct under default equality, genuine duplicate collapse, identity/unmarked-helper controls, marked return-input-unchanged converters, empty/null sets, nested/member/update/patch paths, one-shot enumeration, converter counts, instance receivers, exception identity, and same-driver addition/removal determinism.
Local environment limits
Trimming and Native AOT fail before publish behavior is established at ILLink's ComputeManagedAssemblies task-host creation, with MSB4216 / Unix-domain SocketException 13. PowerShell and clang are absent; 49 PowerShell-dependent tests were not run locally.
The first solution attempt was interrupted by automatic approval-review cancellation during packaging and produced no final packaging TRX. Its completed generator/runtime TRX files plus the completed packaging retry and integration run supply the evidence above. This is not a single all-green local solution run.
Official SDK 10.0.401 and runtimes 8.0.31/9.0.20/10.0.12 use task-local caches/temp and one-processor builds. No assertion, warning, prerequisite, dependency, credential or security setting was weakened.
CI and review
Exact-head CI run 38229815308 passed for
eff1882e994b46034f97d7633b75a28a87101e17.This PR remains draft for human review. No merge, release, tag, package publication or workflow dispatch was performed. This scoped correctness fix does not establish overall release readiness.
Prepared with OpenAI Codex.