Repository navigation
feat: page transitions and motion across Strata, graphite-ui 1.2.0 - #165
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Smoother, more modern motion across Strata, built on graphite-ui 1.2.0 (Project-Graphite/graphite-ui#24). No new dependency. Everything is off under
prefers-reduced-motion: reduce.<details>. List rows fade in.Shellwraps the routed page inPageTransition, so the old page fades out while the new one plays itspage-enterrise.CrashBoundaryno longer needskey={pathname}, because the keyed transition remounts it.ScrollToTopis a layout effect, so the new page is captured at the top.<Amount tween>). The first render shows the final value, so the swap from skeleton stays seamless.Checked on a dev server against the local stack: the view transition, tab underline morph, sidebar and 390px tab bar slides, header, menu, dialog, palette, snackbar, task strike-through and habit animations. Lint and the frontend build pass.
Not seen working in the browser: the task checkbox pop on a real completion and the spending tween, because the local backend went down mid-check.