docs: clarify Ascend soft slicing resource requests#102
Conversation
Signed-off-by: Yuan Fang <yuanfang@alauda.io>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: fyuan1316 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughDocumentation-only update clarifying Ascend soft-slicing usage. README.md's YAML example now includes the ChangesSoft Slicing Documentation Update
Estimated code review effort: 1 (Trivial) | ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
| ### Soft Slicing Configuration (HAMi) | ||
|
|
||
| Use the annotation below whenever you intend **soft** slicing; omitting it keeps **template-based vNPU** behavior (see the note under [Usage in HAMi](#usage-in-hami)). | ||
| Use the annotation below whenever you intend **soft** slicing; omitting it keeps **template-based vNPU** behavior (see the note under [Usage in HAMi](#usage-in-hami)). Soft-sliced workloads should request both **memory** and **core** resources; if only memory is requested, memory may be calculated by hard-slicing template matching, so the actual allocated value may be greater than or equal to the requested value instead of strictly equal to it. |
There was a problem hiding this comment.
delete the if only memory is requested, memory may be calculated by hard-slicing template matching, xxx
Memory allocation is handled by the scheduler. The device-plugin merely transmits the data specified in the annotations to the pod via environment variables. Additionally, you resolved this problem in Project-HAMi/HAMi#2024
Summary
This PR clarifies the recommended resource request pattern for Ascend soft slicing.
When a workload is intended to use
huawei.com/vnpu-mode: hami-core, it should request both memory and core resources. If only memory is requested, memory may be calculated by hard-slicing template matching, so the actual allocated value may be greater than or equal to the requested value instead of strictly equal to it.Changes
huawei.com/Ascend910B-coreto the soft-slicing example.Fixes #101
Test
git diff --checkSummary by CodeRabbit