fix: pass --node_config_file so hami-device-node-config takes effect

[ouyangluwei163]

The ConfigMap is mounted at /node-config.yaml but the DaemonSet args never passed --node_config_file, so main.go never loaded the per-node config. Add the flag to the standalone manifest and Helm chart args. #115

Summary by CodeRabbit

• New Features
  • Added support for loading node-specific configuration through the device plugin deployment.
  • Updated default deployment settings to include the node configuration file alongside the existing device configuration.

[hami-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ouyangluwei163
Once this PR has been reviewed and has the lgtm label, please assign archlitchi for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5dee6ddf-974a-40cf-9444-5f0fffe7d315

📥 Commits

Reviewing files that changed from the base of the PR and between f062939 and 122f777.

📒 Files selected for processing (2)

• ascend-device-plugin.yaml
• charts/ascend-device-plugin/values.yaml

---

📝 Walkthrough

Walkthrough

The device plugin DaemonSet arguments now include --node_config_file /node-config.yaml alongside the existing device configuration argument, in both the standalone manifest and Helm chart values.

Changes

Node configuration wiring

Layer / File(s)	Summary
Add node configuration argument ascend-device-plugin.yaml, charts/ascend-device-plugin/values.yaml	Adds --node_config_file /node-config.yaml to the device-plugin container arguments in both deployment configurations.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related issues

• DaemonSet manifest missing --node_config_file arg, so hami-device-node-config never takes effect #115 — Adds the node configuration argument needed for the mounted configuration to take effect.

Possibly related PRs

• Project-HAMi/ascend-device-plugin#96 — Covers the related mismatch between the mounted node configuration and the container arguments.

Suggested labels: enhancement

Suggested reviewers: dsfans2014, fyuan1316

Poem

A bunny found a config file bright,
And gave the plugin its path just right.
The node settings hop inside,
With device settings by their side.
Deployment blooms in moonlit light.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: adding the --node_config_file flag to enable hami-device-node-config functionality. It accurately reflects the primary objective of the pull request.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}