Skip to content

update image version#117

Merged
hami-robot[bot] merged 1 commit into
Project-HAMi:mainfrom
DSFans2014:feat/version
Jul 24, 2026
Merged

update image version#117
hami-robot[bot] merged 1 commit into
Project-HAMi:mainfrom
DSFans2014:feat/version

Conversation

@DSFans2014

@DSFans2014 DSFans2014 commented Jul 21, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Updates
    • Upgraded the Ascend device plugin image to version 1.4.0.
    • Updated the Helm chart metadata to reflect application version 1.4.0.
    • Refreshed Helm install commands in the documentation to use image.tag=v1.4.0.

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 77e5a0fc-b15b-4341-a6d5-e25a337de8e8

📥 Commits

Reviewing files that changed from the base of the PR and between 287dcd6 and 2d77477.

📒 Files selected for processing (3)
  • ascend-device-plugin.yaml
  • charts/ascend-device-plugin/Chart.yaml
  • charts/ascend-device-plugin/README.md
🚧 Files skipped from review as they are similar to previous changes (2)
  • charts/ascend-device-plugin/Chart.yaml
  • ascend-device-plugin.yaml

📝 Walkthrough

Walkthrough

The DaemonSet image, Helm chart appVersion, and documented installation commands are updated from v1.3.0 to v1.4.0.

Changes

Ascend device plugin version update

Layer / File(s) Summary
Align deployment, chart, and installation version
ascend-device-plugin.yaml, charts/ascend-device-plugin/Chart.yaml, charts/ascend-device-plugin/README.md
The DaemonSet image, Helm chart appVersion, and four Helm installation examples now reference v1.4.0.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested labels: enhancement

Suggested reviewers: archlitchi

Poem

I’m a rabbit with a versioned gleam,
Hopping to v1.4.0’s dream.
Chart and image now match with care,
Fresh install commands join the pair.
Nibble, deploy, and softly run!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: bumping the image version across the manifest, chart, and README.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot added the enhancement New feature or request label Jul 21, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@charts/ascend-device-plugin/Chart.yaml`:
- Line 6: Update the explicit image-tag overrides in the ascend-device-plugin
README installation commands from v1.3.0 to v1.4.0, or remove the overrides so
the chart’s appVersion default is used. Leave other documentation unchanged.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1089aa91-34ce-4206-9162-9868c9311710

📥 Commits

Reviewing files that changed from the base of the PR and between f062939 and 287dcd6.

📒 Files selected for processing (2)
  • ascend-device-plugin.yaml
  • charts/ascend-device-plugin/Chart.yaml

Comment thread charts/ascend-device-plugin/Chart.yaml
Signed-off-by: james <open4pd@4paradigm.com>
@DSFans2014

Copy link
Copy Markdown
Member Author

@archlitchi PTAL

@archlitchi archlitchi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hami-robot

hami-robot Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: archlitchi, DSFans2014

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hami-robot hami-robot Bot added the approved label Jul 24, 2026
@hami-robot
hami-robot Bot merged commit 11fdee2 into Project-HAMi:main Jul 24, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants