update image version#117
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThe DaemonSet image, Helm chart ChangesAscend device plugin version update
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested labels: Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@charts/ascend-device-plugin/Chart.yaml`:
- Line 6: Update the explicit image-tag overrides in the ascend-device-plugin
README installation commands from v1.3.0 to v1.4.0, or remove the overrides so
the chart’s appVersion default is used. Leave other documentation unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 1089aa91-34ce-4206-9162-9868c9311710
📒 Files selected for processing (2)
ascend-device-plugin.yamlcharts/ascend-device-plugin/Chart.yaml
Signed-off-by: james <open4pd@4paradigm.com>
|
@archlitchi PTAL |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: archlitchi, DSFans2014 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary by CodeRabbit
image.tag=v1.4.0.