Skip to content

Fixing the macOS builder#15

Open
WoodleyBrew wants to merge 1 commit intoProject-Plus-Development-Team:masterfrom
FlowerGirlSmug:build-dependencies-fix
Open

Fixing the macOS builder#15
WoodleyBrew wants to merge 1 commit intoProject-Plus-Development-Team:masterfrom
FlowerGirlSmug:build-dependencies-fix

Conversation

@WoodleyBrew
Copy link
Copy Markdown

The macOS builder is currently broken and fails every time, this is a new build-dependencies.sh that fixes it.

Disclaimer: Made using OpenCode AI, not made by me, however it is tested and works.

@FlowerGirlSmug
Copy link
Copy Markdown

FlowerGirlSmug commented Apr 14, 2026

Have no clue why that didn't work because I have the exact file / exact code on my fork and it fixed the issue there?

qtsvg-everywhere-opensource-src-6.2.10.tar.xz: OK
qttools-everywhere-opensource-src-6.2.10.tar.xz: OK
qttranslations-everywhere-opensource-src-6.2.10.tar.xz: OK

Looking at the macOS builder log it was still trying to build the 6.2.10 Qt which is why it failed, not sure what's going on here.

@WoodleyBrew
Copy link
Copy Markdown
Author

I am not an expert on Git / Github and how PR's work but i made a PR for the official P+ Dolphin repo to fix the macOS builder being broken. As of right now if you fork the official repo and try to build using the github actions the macOS builder will fail, as an example I made a fork a few minutes ago and made one tiny change, and the builder did in fact fail for macOS.

The PR I made is here but when performing a run using this it still returned a macOS fail: #15

However, I believe I know why. in ci.yml for the macOS builder the step Checkout Repository checks out the P+ Dev Team's repo using specifically the master branch. Later on there is Build Dependencies which includes run: .github/workflows/scripts/macos/build-dependencies.sh.

So I believe what's happening is despite the PR's run including the new build-dependencies.sh it's still looking at the master branch, which doesn't have the change, and building using the old one. In fact we can see that in the log with

qtbase-everywhere-opensource-src-6.2.10.tar.xz: OK
qtsvg-everywhere-opensource-src-6.2.10.tar.xz: OK
qttools-everywhere-opensource-src-6.2.10.tar.xz: OK
qttranslations-everywhere-opensource-src-6.2.10.tar.xz: OK

It's using the old one rather than the new 6.6.3

I can confirm on multiple forks that this updated build-dependencies.sh works and fixes the macOS builder, i just believe due to the way ci.yml works the PR doesn't satisfy the builder so it looks like it doesn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants