Skip to content

Fix k8s Secret manifest with plaintext CHANGE_ME placeholders #560

Description

@Wilfred007

What

backend-secret.yaml is committed to git with stringData containing CHANGE_ME placeholders for DATABASE_URL, JWT_SECRET, STELLAR_SECRET_KEY. Anyone who deploys without overriding runs with known credentials.

Why

Known credentials in a payroll system is a critical security issue. The secret should use an external secret manager.

Scope

In scope: Use Sealed Secrets or External Secrets Operator, remove plaintext from git, document safe-apply workflow
Out of scope: Vault setup

Acceptance Criteria

  • No plaintext secrets in git
  • External secret manager integration
  • Safe-apply workflow documented
  • Deployment fails if secrets not configured

Technical Context

  • k8s/base/backend-secret.yaml — plaintext placeholders
  • infrastructure/terraform/modules/secrets/ — AWS Secrets Manager

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    GrantFox OSSIssue tracked in GrantFox OSSMaybe RewardedIssue may be eligible for a GrantFox rewardThird CampaignCampaign: Third CampaigndevopsIssues related to infrastructure, CI/CD, and deploymentmediumModerate taskssecurityIssues related to application security and audits

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions