feat: add new constructor for an ecdsa.PublicKey#157
Open
smlx wants to merge 1 commit intoProtonMail:mainfrom
Open
feat: add new constructor for an ecdsa.PublicKey#157smlx wants to merge 1 commit intoProtonMail:mainfrom
smlx wants to merge 1 commit intoProtonMail:mainfrom
Conversation
The existing NewPublicKey was unusable from an external package due to the fact that it used an internal package interface in its function signature. The new constructor uses the elliptic.Curve interface from the standard library instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing NewPublicKey was unusable from an external package due to the fact that it used an internal package interface in its function signature.
The new constructor uses the elliptic.Curve interface from the standard library instead.