Skip to content

Fix unhandled TimeoutError in connect() #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jacob-White-96 wants to merge 1 commit into
base: stable
Choose a base branch
from
Open

Fix unhandled TimeoutError in connect() #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion proton/vpn/cli/core/controller.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,7 +479,10 @@ async def connect(
raise
except (TimeoutError, VPNConnectionError):
# If the connection fails, clean up NM setup
await self.disconnect()
try:
await self.disconnect()
except TimeoutError:
pass # kill switch cleanup timed out, nothing more we can do

connection_state = None
if isinstance(connector.current_state, states.Connected):
Expand Down