Skip to content

[perf] Optimize handler dispatch with snapshot visibility safety #3211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Xekep wants to merge 2 commits into
base: general-devel
Choose a base branch
from
Open

[perf] Optimize handler dispatch with snapshot visibility safety #3211

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b55e5b8
Optimize handler dispatch with copy-on-write snapshots
Xekep Feb 26, 2026
1736b23
Fix handler snapshot publication visibility
Xekep Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions TShockAPI/HandlerList.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ You should have received a copy of the GNU General Public License
using System.Collections.Generic;
using System.ComponentModel;
using System.Linq;
using System.Threading;

namespace TShockAPI
{
Expand All @@ -37,6 +38,7 @@ public class HandlerItem

protected object HandlerLock = new object();
protected List<HandlerItem> Handlers { get; set; }
private HandlerItem[] _handlerSnapshot = Array.Empty<HandlerItem>();
public HandlerList()
{
Handlers = new List<HandlerItem>();
Expand All @@ -59,28 +61,29 @@ public void Register(HandlerItem obj)
{
Handlers.Add(obj);
Handlers = Handlers.OrderBy(h => (int)h.Priority).ToList();
Volatile.Write(ref _handlerSnapshot, Handlers.ToArray());
}
}

public void UnRegister(EventHandler<T> handler)
{
lock (HandlerLock)
{
Handlers.RemoveAll(h => h.Handler.Equals(handler));
if (Handlers.RemoveAll(h => h.Handler.Equals(handler)) > 0)
{
Volatile.Write(ref _handlerSnapshot, Handlers.ToArray());
}
}
}

public void Invoke(object sender, T e)
{
List<HandlerItem> handlers;
lock (HandlerLock)
{
//Copy the list for invoking as to not keep it locked during the invokes
handlers = new List<HandlerItem>(Handlers);
}
var handlers = Volatile.Read(ref _handlerSnapshot);
if (handlers.Length == 0)
return;

var hargs = e as HandledEventArgs;
for (int i = 0; i < handlers.Count; i++)
for (int i = 0; i < handlers.Length; i++)
{
if (hargs == null || !hargs.Handled || (hargs.Handled && handlers[i].GetHandled))
{
Expand Down