Merge Player Trading into Main #24
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Player trading
Player trading
- OnPNObject calls not being triggerred anywhere once the metadata is being updated after trading. Workaround for now is to update when updating the new hat inventory in MetadataNormalization.cs. -Handling situation in SampleMainMenu.cs that is throwing errors when playing the game - it is attempting to access gameobjects no longer in scene since it is now no longer being destroyed when starting the game. -Fixed a bug in player search due to some metadata causing problems.
This reverts commit 9e2bacb.
Player trading
-Integrated Player Trading with Existing System -Storing the chosen hat and avatar in metadata for each user. If a user has never selected a new hat or chosen an avatar, the default avatar and first inventory slot is used. -Trading windows show updated avatars. -Trading window will have the first hat selected in inventories, not the chosen equipped hat. -Trading an equipped hat will result in player equipping the newly traded hat. -Did not encounter issue where users are playing with the hat that was just traded away - they play with the hat that is currently equipped (if there is one)
-Set Chat, Friend, and Settings Button to be non interactive until PubNub loads. -Change how updating username works. Clicking on the Update button next to the nickname field will now update the username for the player.
-Added customizable game length when host is creating a match. 2 min, 20 min, and 60 min. Added to presence state. -Updating username button only interactable once pubnub is enabled and when username is different from existing.
-Updating README with Player Trading Functionality Added. -Code Cleanup
Contributor
|
I found a 'crash' with TradingService.cs. Seems reproducible as follows:
|
|
@darryncampbell-pubnub is there a fix for this pull request? I'm just tryna add trading to my game and would love to add this but not have that issue above.. |
Contributor
|
@LoudStank I'm going to have to defer to @oliverfcarson on this one as I haven't touched the game since last year. @oliverfcarson ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrated Player Trading (DEVX-3358) and fixed the misc bug issues in the Unity Showcase Game (DEVX-3640). Please take a look at the last four commits (starting with commit 0430e15), for more details on what exactly was done, as the earlier commits are from Radoslav).
I wanted to mention two major points of concern:
global, which is affecting total player count. It can also affect the recipient when the window pops up on their end. I have spent way too much time trying to figure out why, as I also cannot reproduce the issue reliably. I did update the readme as this issue being a potential bug that some players might see. Please let me know if you have any major questions.Thanks!