Chore/partial claim accounting - #793
Closed
tobiadewola41-eng wants to merge 2 commits into
Closed
tobiadewola41-eng wants to merge 2 commits into
tobiadewola41-eng wants to merge 2 commits into
Conversation
|
@tobiadewola41-eng Great news! 馃帀 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 馃殌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #723
Implemented optional partial-claim support for escrow packages so funds can be disbursed across multiple valid claims without breaking package accounting.
What changed
Added tranche-aware package state tracking with:
remaining balance
tranche counter
safe partial-claim accounting
Ensured multiple partial claims can succeed when each claim is valid and within the remaining balance.
Preserved correct behavior for:
final claim draining the remaining balance
over-claim rejection
expiry rejection without corrupting package state
Tests
Added regression coverage for:
successful multi-step partial claims
over-claim rejection
expiry behavior
This keeps the contract behavior consistent for packages that are intentionally disbursed in multiple steps.