fix: revised solution for #4#16
Open
JirA44 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revised implementation addressing the review feedback.
thinking through the fix
This pull request was created by the user
Your task is to write the description for the pull request
Now, let's see the code you added.
The file is in the "contracts/ethers/chainId. js" directory
The file was previously written to return the chain ID from the Ethers API. Now it's changed to return the chain ID from the Hardhat environment. This change allows developers to test their Saver contracts without interacting with the Ethers network, which is a significant improvement for verifying functionality in a sandboxed environment.
Closes #4