Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,14 @@
"resolutions": {
"@types/react": "^18.2.12",
"@types/react-native": "^0.70.14",
"basic-ftp": ">=5.2.2",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 basic-ftp resolution floor is below the reported patched version

The PR describes the patched version as 5.3.0, but the resolution is set to >=5.2.2. Any hypothetical 5.2.x release between 5.2.2 and 5.3.0 would satisfy the constraint without carrying the fix. The yarn.lock currently resolves to 5.3.0, so there is no immediate exposure, but aligning the floor with the actual fix boundary is cleaner.

Suggested change
"basic-ftp": ">=5.2.2",
"basic-ftp": ">=5.3.0",
Prompt To Fix With AI
This is a comment left during a code review.
Path: package.json
Line: 30

Comment:
**`basic-ftp` resolution floor is below the reported patched version**

The PR describes the patched version as `5.3.0`, but the resolution is set to `>=5.2.2`. Any hypothetical `5.2.x` release between `5.2.2` and `5.3.0` would satisfy the constraint without carrying the fix. The yarn.lock currently resolves to `5.3.0`, so there is no immediate exposure, but aligning the floor with the actual fix boundary is cleaner.

```suggestion
    "basic-ftp": ">=5.3.0",
```

How can I resolve this? If you propose a fix, please make it concise.

Fix in Claude Code Fix in Cursor Fix in Codex

"brace-expansion": "~1.1.13",
"cacache/glob": "^10.5.0",
"flatted": ">=3.3.4",
"handlebars": ">=4.7.9",
"js-yaml": "^4.1.1",
"lodash": ">=4.17.23",
"lodash-es": ">=4.17.23",
"lodash": ">=4.18.0",
"lodash-es": ">=4.18.0",
"minimatch": "~3.1.3",
"fast-xml-parser": ">=4.5.4",
"tar": ">=7.5.10",
Expand Down
Loading
Loading