Support for multiple CAN/DAQ frames in 1 UDP packet#47
Merged
LelsersLasers merged 9 commits intomasterfrom Apr 22, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the CAN driver abstraction and UDP parsing to support receiving multiple CAN frames within a single UDP datagram, and adapts the CAN processing thread to handle batches of frames.
Changes:
- Changed the driver read API to return a batch of frames (
Vec<CanFrame>) instead of a single frame. - Implemented UDP packet parsing that splits a received datagram into multiple fixed-size raw frames.
- Updated the CAN thread loop to process all frames returned from a single driver read.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/can/thread.rs |
Processes a vector of frames per read instead of a single frame. |
src/can/driver.rs |
Updates the Driver trait + Serial/UDP implementations and adds multi-frame UDP parsing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
Should be tested b4 merge |
LelsersLasers
force-pushed
the
millan/multi_frame_udp
branch
2 times, most recently
from
9296bc4 to
e0fb614
Compare
LelsersLasers
requested review from
irvingywang and
shb-png
and removed request for
shb-png
LelsersLasers
changed the title
shb-png
approved these changes
Apr 21, 2026
irvingywang
approved these changes
Apr 21, 2026
…of just one + implementing for UDP serial just returns a vec of length 1
LelsersLasers
force-pushed
the
millan/multi_frame_udp
branch
from
e0fb614 to
accdeb7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
trait Driver::read_framesreturnsDriverResult<Vec<CanFrame>>instead of just one (DriverResult<CanFrame>) (and renamed accordingly)