Conversation
…d very large sizes, regresses medium sizes.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #86 +/- ##
=======================================
Coverage 99.10% 99.10%
=======================================
Files 10 10
Lines 1566 1566
=======================================
Hits 1552 1552
Misses 14 14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zen4: Improves performance for very small and very large sizes, regresses medium sizes.
M4: Improvement or neutral across the board.
Benchmarks (of the size doubled across the board, even for f32):
double_up_results_zen4.txt
double_up_results_m4.txt
Later we can choose the fastest bit reversal method at runtime, like in #60, but this is a good first step.
Results of
cargo run --release --features=parallel --example benchmark -- 64 27 5Zen4: 1,629,803,842 -> 1,476,104,938
M4: 947,283,858 -> 810,994,608