Skip to content

Fairchem ray serve#3228

Merged
Andrew-S-Rosen merged 30 commits into
Quantum-Accelerators:mainfrom
zulissimeta:fairchem_ray_serve
Jun 9, 2026
Merged

Fairchem ray serve#3228
Andrew-S-Rosen merged 30 commits into
Quantum-Accelerators:mainfrom
zulissimeta:fairchem_ray_serve

Conversation

@zulissimeta

@zulissimeta zulissimeta commented May 8, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Adds an option to use a batching and distributed inference system for all fairchem MLIP inference when

  1. Running the jobs/flows within a ray server and
  2. When FAIRCHEM_RAY_SERVE_BATCHING quacc setting is true

Relies on fairchem>=2.21

Requirements

Note: If you are an external contributor, you will see a comment from @buildbot-princeton. This is solely for the maintainers.

@buildbot-princeton

Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@zulissimeta zulissimeta marked this pull request as draft May 8, 2026 17:05
@Andrew-S-Rosen

Copy link
Copy Markdown
Member

Thanks, @zulissimeta! I'm happy to merge an update like this. Just let me know when it's not in draft. @vineetbansal will help me fix the remaining CI failure separately.

@codecov

codecov Bot commented May 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.65%. Comparing base (62d5f7d) to head (125e06b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3228      +/-   ##
==========================================
+ Coverage   97.64%   97.65%   +0.01%     
==========================================
  Files          98       98              
  Lines        4365     4390      +25     
==========================================
+ Hits         4262     4287      +25     
  Misses        103      103              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Andrew-S-Rosen

Copy link
Copy Markdown
Member

@zulissimeta is this PR still relevant?

@zulissimeta

Copy link
Copy Markdown
Contributor Author

@zulissimeta is this PR still relevant?

Yes, still relevant. Up next now that ray is present in quacc.

@zulissimeta zulissimeta marked this pull request as ready for review May 15, 2026 22:22

@Andrew-S-Rosen Andrew-S-Rosen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zulissimeta Thanks! Just two quick questions from me.

Comment thread src/quacc/recipes/mlp/_base.py Outdated
Comment thread src/quacc/recipes/mlp/_base.py Outdated
@Andrew-S-Rosen

Copy link
Copy Markdown
Member

lgtm! 🚀

@Andrew-S-Rosen Andrew-S-Rosen merged commit 7cd3800 into Quantum-Accelerators:main Jun 9, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants