Skip to content

Ignore zero impressions in Leaderboard #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dewabisma merged 1 commit into from
Jan 23, 2026
Merged

Ignore zero impressions in Leaderboard #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/repositories/raid_leaderboard.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,9 @@ impl RaidLeaderboardRepository {
FROM raid_leaderboards l
WHERE l.raid_id = ",
);

qb.push_bind(raid_id);
qb.push(" AND l.total_impressions > 0 ");
qb.push(" ) ");

qb.push(
Expand Down Expand Up @@ -103,7 +105,7 @@ impl RaidLeaderboardRepository {
a.referrals_count
FROM ranked_entries r
JOIN addresses a ON r.raider_id = a.quan_address
WHERE r.raider_id = $2
WHERE r.raider_id = $2 AND r.total_impressions > 0
";

let entry = sqlx::query_as::<_, RaidLeaderboard>(query)
Expand All @@ -125,6 +127,8 @@ impl RaidLeaderboardRepository {
qb.push(" WHERE l.raid_id = ");
qb.push_bind(raid_id);

qb.push(" AND l.total_impressions > 0 ");

if let Some(code) = referral_code {
qb.push(" AND a.referral_code ILIKE ");
qb.push_bind(format!("{}%", code));
Expand Down Expand Up @@ -191,6 +195,7 @@ mod tests {
("user_high", "REF_HIGH", 1000), // 1000 Impressions
("user_mid", "REF_MID", 500), // 500 Impressions
("user_low", "REF_LOW", 100), // 100 Impressions
("user_zero", "REF_ZERO", 0), // 0 Impressions (Ignored)
];

for (uid, ref_code, impressions) in &users {
Expand Down