Skip to content

security update to fix 'DoS via malicious p2p message'#670

Open
ping-ke wants to merge 3 commits intomasterfrom
p2p-dos
Open

security update to fix 'DoS via malicious p2p message'#670
ping-ke wants to merge 3 commits intomasterfrom
p2p-dos

Conversation

@ping-ke
Copy link
Copy Markdown
Contributor

@ping-ke ping-ke commented Apr 7, 2025

Security issue
DoS via malicious p2p message

Impact
A vulnerable node, can be made to consume unbounded amounts of memory when handling specially crafted p2p messages sent from an attacker node.

Details
The p2p handler spawned a new goroutine to respond to ping requests. By flooding a node with ping requests, an unbounded number of goroutines can be created, leading to resource exhaustion and potentially crash due to OOM.

Ethereum Patches
Fixed by ethereum/go-ethereum#27887

Comment thread p2p/peer.go
@ping-ke ping-ke requested a review from qzhodl April 7, 2025 10:45
Copy link
Copy Markdown

@qzhodl qzhodl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants